[Intel-gfx] [PATCH 27/33] drm/i915: Replace global breadcrumbs with per-context interrupt tracking

[Chris Wilson]

Quoting Chris Wilson (2019-01-25 14:26:49)
> Quoting Tvrtko Ursulin (2019-01-25 13:54:05)
> > 
> > On 25/01/2019 02:29, Chris Wilson wrote:
> > > +
> > > +                     requests[n] = i915_request_get(rq);
> > > +                     i915_request_add(rq);
> > > +
> > > +                     mutex_unlock(BKL);
> > > +
> > > +                     if (err >= 0)
> > > +                             err = i915_sw_fence_await_dma_fence(wait,
> > > +                                                                 &rq->fence,
> > > +                                                                 0,
> > > +                                                                 GFP_KERNEL);
> > 
> > If above is true why this can't simply be i915_request_enable_breadcrumbs?
> 
> I was trying to test breadcrumbs at a high level without 'cheating'.
> 
> For i915_request_enable_breadcrumbs, I keep thinking the test should be
> asking if the engine then has it on its signaling list, but that feels
> like a circular argument, directly following the implementation itself
> 
> > > +                     if (err < 0) {
> > 
> > else if?
> 
> Now where would I be able to copy'n'paste that from? ;)

Actually, no. If it is separate, I'll give you a newline instead.
-Chris