[Intel-gfx] [PATCH 1/2] drm/i915/tv: Fix return value for intel_tv_compute_config()

Imre Deak imre.deak at intel.com
Fri Jan 25 20:03:11 UTC 2019


On Fri, Jan 25, 2019 at 08:19:30PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Ever since commit 204474a6b859 ("drm/i915: Pass down rc in
> intel_encoder->compute_config()") we're supposed to return an
> errno from .compute_config(). I failed to notice that when
> pushing the TV encoder fixes which were written before said
> commmit. Fix up the return value for the error case.
> 
> Cc: Imre Deak <imre.deak at intel.com>
> Fixes: 690157f0a9e7 ("drm/i915/tv: Fix >1024 modes on gen3")
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Reviewed-by: Imre Deak <imre.deak at intel.com>

> ---
>  drivers/gpu/drm/i915/intel_tv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
> index f0b9abda7720..78be08e2971b 100644
> --- a/drivers/gpu/drm/i915/intel_tv.c
> +++ b/drivers/gpu/drm/i915/intel_tv.c
> @@ -1189,7 +1189,7 @@ intel_tv_compute_config(struct intel_encoder *encoder,
>  
>  		if (extra < 0) {
>  			DRM_DEBUG_KMS("No vertical scaling for >1024 pixel wide modes\n");
> -			return false;
> +			return -EINVAL;
>  		}
>  
>  		/* Need to turn off the vertical filter and center the image */
> -- 
> 2.19.2
> 


More information about the Intel-gfx mailing list