[Intel-gfx] [PATCH 07/33] drm/i915/selftests: Apply a subtest filter

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Tue Jan 29 10:37:15 UTC 2019


Quoting Chris Wilson (2019-01-25 04:29:39)
> In bringup on simulated HW even rudimentary tests are slow, and so many
> may fail that we want to be able to filter out the noise to focus on the
> specific problem. Even just the tests groups provided for igt is not
> specific enough, and we would like to isolate one particular subtest
> (and probably subsubtests!). For simplicity, allow the user to provide a
> command line parameter such as
> 
>         i915.st_filter=i915_timeline_mock_selftests/igt_sync
> 
> to restrict ourselves to only running on subtest. The exact name to use
> is given during a normal run, highlighted as an error if it failed,
> debug otherwise. The test group is optional, and then all subtests are
> compared for an exact match with the filter (most subtests have unique
> names). The filter can be negated, e.g. i915.st_filter=!igt_sync and
> then all tests but those that match will be run. More than one match can
> be supplied separated by a comma, e.g.
> 
>         i915.st_filter=igt_vma_create,igt_vma_pin1
> 
> to only run those specified, or
> 
>         i915.st_filter=!igt_vma_create,!igt_vma_pin1
> 
> to run all but those named. Mixing a blacklist and whitelist will only
> execute those subtests matching the whitelist so long as they are
> previously excluded in the blacklist.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

I don't think we have time budger pressure for O(1) solution, so
this is:

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas


More information about the Intel-gfx mailing list