[Intel-gfx] [PATCH v2] drm/i915: Allocate active tracking nodes from a slabcache

Chris Wilson chris at chris-wilson.co.uk
Wed Jan 30 16:47:17 UTC 2019


Quoting Chris Wilson (2019-01-30 16:37:30)
> @@ -20,8 +22,13 @@ static void
>  __active_retire(struct i915_active *ref)
>  {
>         GEM_BUG_ON(!ref->count);
> -       if (!--ref->count)
> -               ref->retire(ref);
> +       if (--ref->count)
> +               return;
> +
> +       /* return the unused nodes to our slabcache*/
> +       i915_active_fini(ref);

This also means the struct is self-finalizing and we only need to use
i915_active_fini() as a sanitycheck. Also if we embed actives
everywhere, debugobject ahoy.
-Chris


More information about the Intel-gfx mailing list