[Intel-gfx] [PATCH 09/11] drm/i915/execlists: Refactor out can_merge_rq()
Tvrtko Ursulin
tvrtko.ursulin at linux.intel.com
Wed Jan 30 18:05:42 UTC 2019
On 30/01/2019 02:19, Chris Wilson wrote:
> In the next patch, we add another user that wants to check whether
> requests can be merge into a single HW execution, and in the future we
> want to add more conditions under which requests from the same context
> cannot be merge. In preparation, extract out can_merge_rq().
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 30 +++++++++++++++++++-----------
> 1 file changed, 19 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 2616b0b3e8d5..e97ce54138d3 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -285,12 +285,11 @@ static inline bool need_preempt(const struct intel_engine_cs *engine,
> }
>
> __maybe_unused static inline bool
> -assert_priority_queue(const struct intel_engine_execlists *execlists,
> - const struct i915_request *prev,
> +assert_priority_queue(const struct i915_request *prev,
> const struct i915_request *next)
> {
> - if (!prev)
> - return true;
> + const struct intel_engine_execlists *execlists =
> + &prev->engine->execlists;
>
> /*
> * Without preemption, the prev may refer to the still active element
> @@ -601,6 +600,17 @@ static bool can_merge_ctx(const struct intel_context *prev,
> return true;
> }
>
> +static bool can_merge_rq(const struct i915_request *prev,
> + const struct i915_request *next)
> +{
> + GEM_BUG_ON(!assert_priority_queue(prev, next));
> +
> + if (!can_merge_ctx(prev->hw_context, next->hw_context))
> + return false;
> +
> + return true;
I'll assume you'll be adding here in the future as the reason this is
not simply "return can_merge_ctx(...)"?
> +}
> +
> static void port_assign(struct execlist_port *port, struct i915_request *rq)
> {
> GEM_BUG_ON(rq == port_request(port));
> @@ -753,8 +763,6 @@ static void execlists_dequeue(struct intel_engine_cs *engine)
> int i;
>
> priolist_for_each_request_consume(rq, rn, p, i) {
> - GEM_BUG_ON(!assert_priority_queue(execlists, last, rq));
> -
> /*
> * Can we combine this request with the current port?
> * It has to be the same context/ringbuffer and not
> @@ -766,8 +774,10 @@ static void execlists_dequeue(struct intel_engine_cs *engine)
> * second request, and so we never need to tell the
> * hardware about the first.
> */
> - if (last &&
> - !can_merge_ctx(rq->hw_context, last->hw_context)) {
> + if (last && !can_merge_rq(last, rq)) {
> + if (last->hw_context == rq->hw_context)
> + goto done;
I don't get this added check. AFAICS it will only trigger with GVT
making it not consider filling both ports if possible.
> +
> /*
> * If we are on the second port and cannot
> * combine this request with the last, then we
> @@ -787,7 +797,6 @@ static void execlists_dequeue(struct intel_engine_cs *engine)
> ctx_single_port_submission(rq->hw_context))
> goto done;
>
> - GEM_BUG_ON(last->hw_context == rq->hw_context);
This is related to the previous comment. Rebase error?
>
> if (submit)
> port_assign(port, last);
> @@ -827,8 +836,7 @@ static void execlists_dequeue(struct intel_engine_cs *engine)
> * request triggering preemption on the next dequeue (or subsequent
> * interrupt for secondary ports).
> */
> - execlists->queue_priority_hint =
> - port != execlists->port ? rq_prio(last) : INT_MIN;
> + execlists->queue_priority_hint = queue_prio(execlists);
This shouldn't be in this patch.
>
> if (submit) {
> port_assign(port, last);
>
Regards,
Tvrtko
More information about the Intel-gfx
mailing list