[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for CRTC background color (rev5)

Patchwork patchwork at emeril.freedesktop.org
Wed Jan 30 19:31:33 UTC 2019


== Series Details ==

Series: CRTC background color (rev5)
URL   : https://patchwork.freedesktop.org/series/50834/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a9fc702b09d5 drm/i915: Force background color to black for gen9+ (v2)
3f404502f7a1 drm: Add CRTC background color property (v4)
-:219: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'shift' - possible side-effects?
#219: FILE: include/uapi/drm/drm_mode.h:931:
+#define DRM_ARGB_COMP(c, shift, numbits) \
+	(__u16)(((c) & 0xFFFFull << (shift)) >> ((shift) + 16 - (numbits)))

total: 0 errors, 0 warnings, 1 checks, 132 lines checked
f96a4d9be129 drm/i915/gen9+: Add support for pipe background color (v4)
-:45: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t'
#45: FILE: drivers/gpu/drm/i915/i915_debugfs.c:3096:
+			uint64_t background = pipe_config->base.bgcolor;

-:69: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t'
#69: FILE: drivers/gpu/drm/i915/intel_display.c:3904:
+	uint64_t propval = crtc_state->base.bgcolor;

-:70: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t'
#70: FILE: drivers/gpu/drm/i915/intel_display.c:3905:
+	uint32_t tmp;

total: 0 errors, 0 warnings, 3 checks, 104 lines checked



More information about the Intel-gfx mailing list