[Intel-gfx] [PATCH 3/3] drm/i915: Allocate active tracking nodes from a slabcache

Chris Wilson chris at chris-wilson.co.uk
Thu Jan 31 11:41:29 UTC 2019


Quoting Tvrtko Ursulin (2019-01-31 11:39:46)
> 
> 
> On 30/01/2019 20:50, Chris Wilson wrote:
> > Wrap the active tracking for a GPU references in a slabcache for faster
> > allocations, and hopefully better fragmentation reduction.
> >
> 
> v2 where art thou? :)

You killed v2!

> > v3: Nothing device specific left, it's just a slabcache that we can
> > make global.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > ---
> > diff --git a/drivers/gpu/drm/i915/i915_active.h b/drivers/gpu/drm/i915/i915_active.h
> > index 6130c6770d10..48fdb1497883 100644
> > --- a/drivers/gpu/drm/i915/i915_active.h
> > +++ b/drivers/gpu/drm/i915/i915_active.h
> > @@ -63,4 +63,7 @@ void i915_active_fini(struct i915_active *ref);
> >   static inline void i915_active_fini(struct i915_active *ref) { }
> >   #endif
> >   
> > +int i915_global_active_init(void);
> > +void i915_global_active_exit(void);
> > +
> >   #endif /* _I915_ACTIVE_H_ */
> > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> > index 44c23ac60347..751a787c83d1 100644
> > --- a/drivers/gpu/drm/i915/i915_pci.c
> > +++ b/drivers/gpu/drm/i915/i915_pci.c
> 
> Add explicit #include "i915_active.h"?

Indeed.
-Chris


More information about the Intel-gfx mailing list