[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm: report dp downstream port type as a subconnector property

Patchwork patchwork at emeril.freedesktop.org
Mon Jul 1 09:37:50 UTC 2019


== Series Details ==

Series: series starting with [1/2] drm: report dp downstream port type as a subconnector property
URL   : https://patchwork.freedesktop.org/series/63026/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e4c5221b85cd drm: report dp downstream port type as a subconnector property
-:31: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Unknown>
#31: FILE: drivers/gpu/drm/drm_connector.c:796:
+	{ DRM_MODE_SUBCONNECTOR_Unknown,   "Unknown"   }, /* DVI-I, TV-out and DP */

-:54: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Wireless>
#54: FILE: drivers/gpu/drm/drm_connector.c:828:
+	{ DRM_MODE_SUBCONNECTOR_Wireless,  "Wireless"  }, /* DP */

-:55: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Native>
#55: FILE: drivers/gpu/drm/drm_connector.c:829:
+	{ DRM_MODE_SUBCONNECTOR_Native,	   "Native"    }, /* DP */

-:202: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Automatic>
#202: FILE: include/uapi/drm/drm_mode.h:335:
+	DRM_MODE_SUBCONNECTOR_Automatic  = 0,  /* DVI-I, TV     */

-:208: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Composite>
#208: FILE: include/uapi/drm/drm_mode.h:341:
+	DRM_MODE_SUBCONNECTOR_Composite  = 5,  /*        TV     */

-:210: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Component>
#210: FILE: include/uapi/drm/drm_mode.h:343:
+	DRM_MODE_SUBCONNECTOR_Component  = 8,  /*        TV     */

total: 0 errors, 0 warnings, 6 checks, 164 lines checked
eafc29b760a7 drm/i915: utilize subconnector property for DP
-:19: CHECK:LINE_SPACING: Please don't use multiple blank lines
#19: FILE: drivers/gpu/drm/i915/display/intel_dp.c:5535:
 
+

-:27: CHECK:CAMELCASE: Avoid CamelCase: <DRM_MODE_SUBCONNECTOR_Unknown>
#27: FILE: drivers/gpu/drm/i915/display/intel_dp.c:5546:
+	enum drm_mode_subconnector subconnector = DRM_MODE_SUBCONNECTOR_Unknown;

-:36: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#36: FILE: drivers/gpu/drm/i915/display/intel_dp.c:5639:
+		subconnector = drm_dp_downstream_subconnector_type(

-:41: WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'connector->dev->mode_config.dp_subconnector_property'
#41: FILE: drivers/gpu/drm/i915/display/intel_dp.c:5644:
+				      connector->dev->
+				      mode_config.dp_subconnector_property,

total: 0 errors, 1 warnings, 3 checks, 39 lines checked



More information about the Intel-gfx mailing list