[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Bigjoiner atomic preparations.

Patchwork patchwork at emeril.freedesktop.org
Tue Jul 2 21:30:19 UTC 2019


== Series Details ==

Series: Bigjoiner atomic preparations.
URL   : https://patchwork.freedesktop.org/series/63094/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b9e17bf6bac7 drm/i915: Prepare to split crtc state in uapi and hw state
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11: 
- crtc, *_changed flags, event, commit, state, mode_blob, (plane/connector/encoder)_mask.

-:1968: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1968: FILE: drivers/gpu/drm/i915/display/intel_display.c:11139:
+	crtc_state->uapi.active = crtc_state->uapi.enable = true;

-:2625: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#2625: FILE: drivers/gpu/drm/i915/display/intel_display.c:16640:
+		crtc_state->hw.active = crtc_state->hw.enable =

-:3731: ERROR:CODE_INDENT: code indent should use tabs where possible
#3731: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:223:
+^I^I^I^I          new_crtc_state->uapi.event);$

-:3731: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#3731: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:223:
+		drm_crtc_arm_vblank_event(&crtc->base,
+				          new_crtc_state->uapi.event);

total: 1 errors, 1 warnings, 3 checks, 4166 lines checked
fe8910ead298 drm/i915: Handle a few more cases for hw/sw split
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 118 lines checked
d31a4fc4501d drm/i915: Complete sw/hw split
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 201 lines checked
9516b4dffdfa drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid()
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 22 lines checked
1909a2665a65 drm/i915/dp: Validate modes that can only be handled in a bigjoiner configuration
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 307 lines checked
deb270f134b8 drm/i915: Try to make bigjoiner work in atomic check.
-:54: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#54: FILE: drivers/gpu/drm/i915/display/intel_display.c:12237:
+	crtc_state->nv12_planes = crtc_state->c8_planes = crtc_state->update_planes = 0;

-:74: WARNING:LONG_LINE: line over 100 characters
#74: FILE: drivers/gpu/drm/i915/display/intel_display.c:13624:
+	struct intel_crtc_state *old_crtc_state, *new_crtc_state, *slave_crtc_state, *master_crtc_state;

total: 0 errors, 1 warnings, 1 checks, 230 lines checked
f41590956879 drm/i915: Allow vdsc functions to be called without encoder.



More information about the Intel-gfx mailing list