[Intel-gfx] [PATCH 1/2] drm: report dp downstream port type as a subconnector property

Emil Velikov emil.l.velikov at gmail.com
Wed Jul 3 13:35:42 UTC 2019


On Wed, 3 Jul 2019 at 09:19, Vasilev, Oleg <oleg.vasilev at intel.com> wrote:
>
> On Tue, 2019-07-02 at 14:38 +0100, Emil Velikov wrote:
> > Hi Oleg,
> >
> > On Mon, 1 Jul 2019 at 09:00, Oleg Vasilev <oleg.vasilev at intel.com>
> > wrote:
> > > Currently, downstream port type is only reported in debugfs. This
> > > information should be considered important since it reflects the
> > > actual
> > > physical connector type. Some userspace (e.g. window compositors)
> > > may want to show this info to a user.
> > >
> > > The 'subconnector' property is already utilized for DVI-I and TV-
> > > out for
> > > reporting connector subtype.
> > >
> > > The initial motivation for this feature came from i2c test [1].
> > > It is supposed to be skipped on VGA connectors, but it cannot
> > > detect VGA over DP and fails instead.
> > >
> > > [1]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
> > > Signed-off-by: Oleg Vasilev <oleg.vasilev at intel.com>
> > > ---
> > >  drivers/gpu/drm/drm_connector.c | 38
> > > +++++++++++++++++++++++++++++++--
> > >  drivers/gpu/drm/drm_dp_helper.c | 36
> > > +++++++++++++++++++++++++++++++
> > >  include/drm/drm_connector.h     |  2 ++
> > >  include/drm/drm_dp_helper.h     |  3 +++
> > >  include/drm/drm_mode_config.h   |  6 ++++++
> > >  include/uapi/drm/drm_mode.h     | 22 ++++++++++++-------
> > >  6 files changed, 97 insertions(+), 10 deletions(-)
> > >
> > Can you please update other drivers to make use of this - quick grep
> > shows 5-10 in total.
>
> Hi,
>
> Sure, I can do this. Should I do this is a part of this series or
> better first get it merged, and then add support for other drivers?
>
Since it's a very small list, personally I'd go with part of this series.
If others feel differently go with that.

Please don't forget to address Ville feedback.

Thanks
Emil


More information about the Intel-gfx mailing list