[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Random plane stuff

Patchwork patchwork at emeril.freedesktop.org
Wed Jul 3 20:23:03 UTC 2019


== Series Details ==

Series: drm/i915: Random plane stuff
URL   : https://patchwork.freedesktop.org/series/63165/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
1ff2050e6961 drm/i915: Add windowing for primary planes on gen2/3 and chv
6d8562411672 drm/i915: Disable sprite gamma on ivb-bdw
48977b250275 drm/i915: Program plane gamma ramps
-:235: WARNING:LONG_LINE_COMMENT: line over 100 characters
#235: FILE: drivers/gpu/drm/i915/i915_reg.h:6307:
+#define DSPGAMC(plane, i)	_MMIO(_PIPE2(plane, _DSPAGAMC) + (5 - (i)) * 4) /* plane C only, 6 x u0.8 */

-:273: WARNING:LONG_LINE_COMMENT: line over 100 characters
#273: FILE: drivers/gpu/drm/i915/i915_reg.h:6450:
+#define DVSGAMC_G4X(pipe, i) _MMIO(_PIPE(pipe, _DVSAGAMC_G4X, _DVSBGAMC_G4X) + (5 - (i)) * 4) /* 6 x u0.8 */

-:274: WARNING:LONG_LINE_COMMENT: line over 100 characters
#274: FILE: drivers/gpu/drm/i915/i915_reg.h:6451:
+#define DVSGAMC_ILK(pipe, i) _MMIO(_PIPE(pipe, _DVSAGAMC_ILK, _DVSBGAMC_ILK) + (i) * 4) /* 16 x u0.10 */

-:275: WARNING:LONG_LINE_COMMENT: line over 100 characters
#275: FILE: drivers/gpu/drm/i915/i915_reg.h:6452:
+#define DVSGAMCMAX_ILK(pipe, i) _MMIO(_PIPE(pipe, _DVSAGAMCMAX_ILK, _DVSBGAMCMAX_ILK) + (i) * 4) /* 3 x u1.10 */

-:337: WARNING:LONG_LINE: line over 100 characters
#337: FILE: drivers/gpu/drm/i915/i915_reg.h:6612:
+#define SPGAMC(pipe, plane_id, i)	_MMIO(_VLV_SPR((pipe), (plane_id), _SPAGAMC, _SPBGAMC) + (5 - (i)) * 4) /* 6 x u0.10 */

total: 0 errors, 5 warnings, 0 checks, 290 lines checked
75a7d8dc333d drm/i915: Deal with cpp==8 for g4x watermarks
e0f52dc72556 drm/i915: Cosmetic fix for skl+ plane switch statement
4e3e480905a8 drm/i915: Clean up skl vs. icl plane formats
-:148: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#148: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:2343:
+		return skl_planar_formats;
+	} else {

-:161: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#161: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:2356:
+		return glk_planar_formats;
+	} else {

-:177: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#177: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:2372:
+		return icl_sdr_y_plane_formats;
+	} else {

total: 0 errors, 3 warnings, 0 checks, 191 lines checked



More information about the Intel-gfx mailing list