[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for EHL port programming (rev6)

[Patchwork]

== Series Details ==

Series: EHL port programming (rev6)
URL   : https://patchwork.freedesktop.org/series/62492/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
4cf1d095c089 drm/i915/gen11: Start distinguishing 'phy' from 'port'
7e9f8a5e5eec drm/i915/gen11: Program DPCLKA_CFGCR0_ICL according to PHY
-:216: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc_port' - possible side-effects?
#216: FILE: drivers/gpu/drm/i915/i915_reg.h:9692:
+#define  ICL_DPCLKA_CFGCR0_TC_CLK_OFF(tc_port) (1 << ((tc_port) == PORT_TC4 ? \
+						      21 : (tc_port) + 12))

-:219: WARNING:LONG_LINE: line over 100 characters
#219: FILE: drivers/gpu/drm/i915/i915_reg.h:9695:
+#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy)	(3 << ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))

-:220: WARNING:LONG_LINE: line over 100 characters
#220: FILE: drivers/gpu/drm/i915/i915_reg.h:9696:
+#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy)	((pll) << ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))

total: 0 errors, 2 warnings, 1 checks, 173 lines checked
7103f4d8a0ab drm/i915/gen11: Convert combo PHY logic to use new 'enum phy' namespace
-:346: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__phy' - possible side-effects?
#346: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:9:
+#define for_each_combo_phy(__dev_priv, __phy) \
+	for ((__phy) = PHY_A; (__phy) < I915_MAX_PHYS; (__phy)++)	\
+		for_each_if(intel_phy_is_combo(__dev_priv, __phy))

-:353: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__phy' - possible side-effects?
#353: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:13:
+#define for_each_combo_phy_reverse(__dev_priv, __phy) \
+	for ((__phy) = I915_MAX_PHYS; (__phy)-- > PHY_A;) \
+		for_each_if(intel_phy_is_combo(__dev_priv, __phy))

-:826: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__phy' - possible side-effects?
#826: FILE: drivers/gpu/drm/i915/display/intel_display.h:271:
+#define for_each_phy_masked(__phy, __phys_mask) \
+	for ((__phy) = PHY_A; (__phy) < I915_MAX_PHYS; (__phy)++)	\
+		for_each_if((__phys_mask) & BIT(__phy))

-:1006: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1006: FILE: drivers/gpu/drm/i915/i915_reg.h:1880:
+#define CNL_PORT_PCS_DW1_LN0(phy)	_MMIO(_PICK(phy, \
 						    _CNL_PORT_PCS_DW1_LN0_AE, \
 						    _CNL_PORT_PCS_DW1_LN0_B, \
 						    _CNL_PORT_PCS_DW1_LN0_C, \

total: 1 errors, 0 warnings, 3 checks, 998 lines checked
4651fa91a8ce drm/i915: Transition port type checks to phy checks
09dfa8996618 drm/i915/ehl: Enable DDI-D