[Intel-gfx] [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Chris Wilson]

Quoting Michal Wajdeczko (2019-07-03 14:02:51)
> On Wed, 03 Jul 2019 13:40:06 +0200, Chris Wilson  
> <chris at chris-wilson.co.uk> wrote:
> 
> > Quoting Michal Wajdeczko (2019-07-03 12:36:40)
> >> GuC firmware is now mature, so let it run by default.
> >> Note that today GuC is only used for HuC authentication.
> >
> > https://bugs.freedesktop.org/show_bug.cgi?id=110617 ?
> 
> Above bug was found on suspicious kernel with old GuC 9.39:
> 
> [    2.381803] [drm] HuC: Loaded firmware i915/kbl_huc_ver02_00_1810.bin  
> (version 2.0)
> [    2.386316] [drm] GuC: Loaded firmware i915/kbl_guc_ver9_39.bin  
> (version 9.39)
> [    2.438318] [drm:intel_huc_auth] *ERROR* HuC: Firmware not verified  
> 0x6000
> [    2.445235] [drm:intel_huc_auth] *ERROR* HuC: Authentication failed -110
> [    2.451975] i915 0000:00:02.0: GuC initialization failed -110
> 
> while results from try-bot [1] with 33.0.0 on KBL are looking fine:
> 
> [    3.854084] [drm] HuC: Loaded firmware i915/kbl_huc_ver02_00_1810.bin  
> (version 2.0)
> [    3.865419] [drm] GuC: Loaded firmware i915/kbl_guc_33.0.0.bin (version  
> 33.0)
> [    3.876243] i915 0000:00:02.0: GuC submission disabled
> [    3.876245] i915 0000:00:02.0: HuC enabled
> 
> Note that newer GuC fixes other known issue [2] that has similar signature:
> 
> [160.168623] [drm:intel_huc_auth [i915]] *ERROR* HuC: Firmware not  
> verified -110
> [160.168839] [drm:intel_huc_auth [i915]] *ERROR* HuC: Authentication  
> failed -110
> [160.169159] [drm:i915_gem_init_hw [i915]] *ERROR* Enabling uc failed  
> (-110)

Pushed the switch to the new GuC version, but I am deferring the
decision to enable-by-default to someone in MAINTAINERS. Probably Joonas
if he survives his swim with the fishes.
-Chris