[Intel-gfx] [PATCH v4 4/5] drm/i915: Transition port type checks to phy checks

[kbuild test robot]

Hi Matt,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20190704]
[cannot apply to v5.2-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Matt-Roper/EHL-port-programming/20190704-143105
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-6) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp at intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/display/intel_display_power.c: In function 'icl_tc_port_assert_ref_held':
>> drivers/gpu/drm/i915/display/intel_display_power.c:490:36: error: incompatible type for argument 1 of 'intel_port_to_phy'
      enum phy phy = intel_port_to_phy(encoder->port);
                                       ^~~~~~~
   In file included from drivers/gpu/drm/i915/i915_drv.h:67:0,
                    from drivers/gpu/drm/i915/display/intel_display_power.c:11:
   drivers/gpu/drm/i915/display/intel_display.h:378:10: note: expected 'struct drm_i915_private *' but argument is of type 'enum port'
    enum phy intel_port_to_phy(struct drm_i915_private *i915, enum port port);
             ^~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/display/intel_display_power.c:490:18: error: too few arguments to function 'intel_port_to_phy'
      enum phy phy = intel_port_to_phy(encoder->port);
                     ^~~~~~~~~~~~~~~~~
   In file included from drivers/gpu/drm/i915/i915_drv.h:67:0,
                    from drivers/gpu/drm/i915/display/intel_display_power.c:11:
   drivers/gpu/drm/i915/display/intel_display.h:378:10: note: declared here
    enum phy intel_port_to_phy(struct drm_i915_private *i915, enum port port);
             ^~~~~~~~~~~~~~~~~

vim +/intel_port_to_phy +490 drivers/gpu/drm/i915/display/intel_display_power.c

   474	
   475	static void icl_tc_port_assert_ref_held(struct drm_i915_private *dev_priv,
   476						struct i915_power_well *power_well)
   477	{
   478		enum aux_ch aux_ch = icl_tc_phy_aux_ch(dev_priv, power_well);
   479		struct intel_digital_port *dig_port = NULL;
   480		struct intel_encoder *encoder;
   481	
   482		/* Bypass the check if all references are released asynchronously */
   483		if (power_well_async_ref_count(dev_priv, power_well) ==
   484		    power_well->count)
   485			return;
   486	
   487		aux_ch = icl_tc_phy_aux_ch(dev_priv, power_well);
   488	
   489		for_each_intel_encoder(&dev_priv->drm, encoder) {
 > 490			enum phy phy = intel_port_to_phy(encoder->port);
   491	
   492			if (!intel_phy_is_tc(dev_priv, phy))
   493				continue;
   494	
   495			/* We'll check the MST primary port */
   496			if (encoder->type == INTEL_OUTPUT_DP_MST)
   497				continue;
   498	
   499			dig_port = enc_to_dig_port(&encoder->base);
   500			if (WARN_ON(!dig_port))
   501				continue;
   502	
   503			if (dig_port->aux_ch != aux_ch) {
   504				dig_port = NULL;
   505				continue;
   506			}
   507	
   508			break;
   509		}
   510	
   511		if (WARN_ON(!dig_port))
   512			return;
   513	
   514		WARN_ON(!intel_tc_port_ref_held(dig_port));
   515	}
   516	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 68695 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20190705/0930c432/attachment-0001.gz>