[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/11] drm/i915/gtt: Use shallow dma pages for scratch

Patchwork patchwork at emeril.freedesktop.org
Sun Jul 7 21:41:19 UTC 2019


== Series Details ==

Series: series starting with [01/11] drm/i915/gtt: Use shallow dma pages for scratch
URL   : https://patchwork.freedesktop.org/series/63329/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
46b4d072b194 drm/i915/gtt: Use shallow dma pages for scratch
627dff785897 drm/i915/gtt: Wrap page_table with page_directory
-:392: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'px' - possible side-effects?
#392: FILE: drivers/gpu/drm/i915/i915_gem_gtt.h:261:
+#define px_base(px) \
+	__px_choose_expr(px, struct i915_page_dma *, __x, \
+	__px_choose_expr(px, struct i915_page_table *, &__x->base, \
+	__px_choose_expr(px, struct i915_page_directory *, &__x->pt.base, \
+	(void)0)))

-:399: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'px' - possible side-effects?
#399: FILE: drivers/gpu/drm/i915/i915_gem_gtt.h:268:
+#define px_pt(px) \
+	__px_choose_expr(px, struct i915_page_table *, __x, \
+	__px_choose_expr(px, struct i915_page_directory *, &__x->pt, \
+	(void)0))

total: 0 errors, 0 warnings, 2 checks, 368 lines checked
3d125ca5b87e drm/i915/gtt: Reorder gen8 ppgtt free/clear/alloc
-:370: WARNING:LINE_SPACING: Missing a blank line after declarations
#370: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:1194:
+	dma_addr_t addr = sg_dma_address(sg);
+	return (struct sgt_dma) { sg, addr, addr + sg->length };

total: 0 errors, 1 warnings, 0 checks, 717 lines checked
ce67216bdcb8 drm/i915/gtt: Markup i915_ppgtt depth
4eeec22243cc drm/i915/gtt: Compute the radix for gen8 page table levels
04fdd50e75e5 drm/i915/gtt: Convert vm->scratch into an array
180600ec7746 drm/i915/gtt: Use NULL to encode scratch shadow entries
71da10070ceb drm/i915/gtt: Recursive cleanup for gen8
7537f8c4b528 drm/i915/gtt: Recursive ppgtt clear for gen8
22c1df3cb640 drm/i915/gtt: Recursive ppgtt alloc for gen8
53d77f98424d drm/i915/gtt: Tidy up ppgtt insertion for gen8
-:235: WARNING:LONG_LINE: line over 100 characters
#235: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:1328:
+							    i915_pd_entry(pml4, gen8_pd_index(idx, 3)),

total: 0 errors, 1 warnings, 0 checks, 336 lines checked



More information about the Intel-gfx mailing list