[Intel-gfx] [PATCH 2/2] drm/i915/gt: Remove presumption of RCS0

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Tue Jul 9 06:30:17 UTC 2019


On 05/07/2019 13:43, Chris Wilson wrote:
> We now track features correctly instead of probing i915->engine[RCS0]
> which is much more flexible and avoids any nasty surprises.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
>   drivers/gpu/drm/i915/gt/intel_engine_cs.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> index df5932f5f578..bdf279fa3b2e 100644
> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> @@ -448,12 +448,6 @@ int intel_engines_init_mmio(struct drm_i915_private *i915)
>   	if (WARN_ON(mask != engine_mask))
>   		device_info->engine_mask = mask;
>   
> -	/* We always presume we have at least RCS available for later probing */
> -	if (WARN_ON(!HAS_ENGINE(i915, RCS0))) {
> -		err = -ENODEV;
> -		goto cleanup;
> -	}
> -
>   	RUNTIME_INFO(i915)->num_engines = hweight32(mask);
>   
>   	intel_gt_check_and_clear_faults(&i915->gt);
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko


More information about the Intel-gfx mailing list