[Intel-gfx] [PATCH 8/8] drm/i915/gt: Use intel_gt as the primary object for handling resets

Chris Wilson chris at chris-wilson.co.uk
Tue Jul 9 08:15:10 UTC 2019


Quoting Daniele Ceraolo Spurio (2019-07-08 23:48:51)
> On 7/5/19 12:46 AM, Chris Wilson wrote:
> > diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
> > index 2d9cc3cd1f27..8caad19683a1 100644
> > --- a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
> > +++ b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c
> 
> > @@ -442,7 +441,7 @@ static int igt_reset_nop(void *arg)
> >   
> >   out:
> >       mock_file_free(i915, file);
> > -     if (i915_reset_failed(i915))
> > +     if (intel_gt_is_wedged(&i915->gt))
> 
> &i915->gt is used 5 times in igt_reset_nop(), might be worth having a 
> local variable.

Oh, this is before intel_gt_live_selftests() :)

I changed it so that we passed intel_gt as the arg to these selftests.
-Chris


More information about the Intel-gfx mailing list