[Intel-gfx] [PATCH v6 03/11] drm/i915/perf: allow for CS OA configs to be created lazily

[Chris Wilson]

Quoting Lionel Landwerlin (2019-07-09 07:47:04)
> On 01/07/2019 18:09, Chris Wilson wrote:
> > Quoting Lionel Landwerlin (2019-07-01 12:34:29)
> >> +       if (metrics_set == 1) {
> >> +               oa_config = &i915->perf.oa.test_config;
> >> +       } else {
> >> +               oa_config = idr_find(&i915->perf.metrics_idr, metrics_set);
> > Why not have the builtin[1] inside the idr?
> 
> 
> I think it was just a way to avoid removing it from the idr through 
> userspace calls.

It might just be simpler to have the filter in the ioctl?
if (arg->id <= BUILTINS)
	return -EINVAL;
-Chris