[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for EHL port programming (rev7)

[Patchwork]

== Series Details ==

Series: EHL port programming (rev7)
URL   : https://patchwork.freedesktop.org/series/62492/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
0cd776d3f169 drm/i915/gen11: Start distinguishing 'phy' from 'port'
97ceed65bf2b drm/i915/gen11: Program ICL_DPCLKA_CFGCR0 according to PHY
-:265: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc_port' - possible side-effects?
#265: FILE: drivers/gpu/drm/i915/i915_reg.h:9709:
+#define  ICL_DPCLKA_CFGCR0_TC_CLK_OFF(tc_port) (1 << ((tc_port) == PORT_TC4 ? \
+						      21 : (tc_port) + 12))

-:268: WARNING:LONG_LINE: line over 100 characters
#268: FILE: drivers/gpu/drm/i915/i915_reg.h:9712:
+#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy)	(3 << ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))

-:269: WARNING:LONG_LINE: line over 100 characters
#269: FILE: drivers/gpu/drm/i915/i915_reg.h:9713:
+#define  ICL_DPCLKA_CFGCR0_DDI_CLK_SEL(pll, phy)	((pll) << ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy))

total: 0 errors, 2 warnings, 1 checks, 212 lines checked
2550905e56cc drm/i915/gen11: Convert combo PHY logic to use new 'enum phy' namespace
-:352: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__phy' - possible side-effects?
#352: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:9:
+#define for_each_combo_phy(__dev_priv, __phy) \
+	for ((__phy) = PHY_A; (__phy) < I915_MAX_PHYS; (__phy)++)	\
+		for_each_if(intel_phy_is_combo(__dev_priv, __phy))

-:359: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__phy' - possible side-effects?
#359: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:13:
+#define for_each_combo_phy_reverse(__dev_priv, __phy) \
+	for ((__phy) = I915_MAX_PHYS; (__phy)-- > PHY_A;) \
+		for_each_if(intel_phy_is_combo(__dev_priv, __phy))

-:835: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__phy' - possible side-effects?
#835: FILE: drivers/gpu/drm/i915/display/intel_display.h:271:
+#define for_each_phy_masked(__phy, __phys_mask) \
+	for ((__phy) = PHY_A; (__phy) < I915_MAX_PHYS; (__phy)++)	\
+		for_each_if((__phys_mask) & BIT(__phy))

-:1015: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1015: FILE: drivers/gpu/drm/i915/i915_reg.h:1880:
+#define CNL_PORT_PCS_DW1_LN0(phy)	_MMIO(_PICK(phy, \
 						    _CNL_PORT_PCS_DW1_LN0_AE, \
 						    _CNL_PORT_PCS_DW1_LN0_B, \
 						    _CNL_PORT_PCS_DW1_LN0_C, \

total: 1 errors, 0 warnings, 3 checks, 1001 lines checked
2d193fd97d83 drm/i915: Transition port type checks to phy checks
a188f8f668e0 drm/i915/ehl: Enable DDI-D