[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/14] drm/i915/execlists: Record preemption for selftests

Patchwork patchwork at emeril.freedesktop.org
Wed Jul 10 07:01:17 UTC 2019


== Series Details ==

Series: series starting with [01/14] drm/i915/execlists: Record preemption for selftests
URL   : https://patchwork.freedesktop.org/series/63472/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
33497b9b47fa drm/i915/execlists: Record preemption for selftests
cd4cbb2e09df drm/i915/selftests: Hold the vma manager lock while modifying mmap_offset
2b9490653a65 drm/i915: Lock the engine while dumping the active request
1045e6b87a13 drm/i915: Rely on spinlock protection for GPU error capture
46eccca39b85 drm/i915/oa: Reconfigure contexts on the fly
db011dc04e92 drm/i915: Add to timeline requires the timeline mutex
f7c1dc7807d9 drm/i915: Teach execbuffer to take the engine wakeref not GT
cae180105fbf drm/i915/gt: Track timeline activeness in enter/exit
c241cf080e29 drm/i915/gt: Convert timeline tracking to spinlock
669f1232b7af drm/i915/gt: Guard timeline pinning with its own mutex
65a1ba1cf5c2 drm/i915: Protect request retirement with timeline->mutex
62b812f545fa drm/i915: Replace struct_mutex for batch pool serialisation
-:305: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#305: 
new file mode 100644

-:310: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#310: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.c:1:
+/*

-:311: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#311: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.c:2:
+ * SPDX-License-Identifier: MIT

-:500: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#500: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.h:1:
+/*

-:501: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#501: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.h:2:
+ * SPDX-License-Identifier: MIT

-:540: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#540: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:1:
+/*

-:541: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#541: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:2:
+ * SPDX-License-Identifier: MIT

-:557: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#557: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:18:
+	spinlock_t lock;

total: 0 errors, 7 warnings, 1 checks, 613 lines checked
8ff775ec813b drm/i915/gt: Mark context->active_count as protected by timeline->mutex
77c2532bf35e drm/i915/gt: Use intel_gt as the primary object for handling resets
-:27: WARNING:MEMORY_BARRIER: memory barrier without comment
#27: FILE: drivers/gpu/drm/i915/display/intel_display.c:4275:
+	smp_mb__after_atomic();

-:1826: WARNING:MEMORY_BARRIER: memory barrier without comment
#1826: FILE: drivers/gpu/drm/i915/gt/intel_reset.c:1269:
+	smp_mb__after_atomic();

-:2051: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'W' - possible side-effects?
#2051: FILE: drivers/gpu/drm/i915/gt/intel_reset.h:64:
+#define intel_wedge_on_timeout(W, GT, TIMEOUT)				\
+	for (__intel_init_wedge((W), (GT), (TIMEOUT), __func__);	\
+	     (W)->gt;							\
+	     __intel_fini_wedge((W)))

-:2066: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#2066: 
new file mode 100644

-:4479: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'T' - possible side-effects?
#4479: FILE: drivers/gpu/drm/i915/i915_selftest.h:94:
+#define intel_gt_live_subtests(T, data) ({ \
+	typecheck(struct intel_gt *, data); \
+	__i915_subtests(__func__, \
+			__intel_gt_live_setup, __intel_gt_live_teardown, \
+			T, ARRAY_SIZE(T), data); \
+})

total: 0 errors, 3 warnings, 2 checks, 4298 lines checked



More information about the Intel-gfx mailing list