[Intel-gfx] [PATCH 00/12] GT-fy the uc code

Chris Wilson chris at chris-wilson.co.uk
Wed Jul 10 13:02:13 UTC 2019


Quoting Daniele Ceraolo Spurio (2019-07-10 01:54:25)
> GuC and HuC are a subunits of the GT HW, so it makes sense for the
> relevant structures to be inside intel_gt. This series introduces a new
> intel_uc structure under intel_gt and moves the GuC/HuC structures in
> there. All the general uc code is then encapsulated, working on intel_uc
> instead of i915.
> 
> Note that a bit of ugliness is inroduced with the move because we have a
> lot of layers (i915->gt.uc.guc.fw). Most of these "deep" accesses are
> removed by the later patches in the series, but some of them remain,
> mainly in debugfs functions. Follow up updates to make the code more
> encapsulated should help cleaning up.

Fwiw, this series convinced me that gt/uc is the right way to structure
it. We just need to fixup the log_wq handling and grab a few acks/reviews
from Michal et al.
-Chris


More information about the Intel-gfx mailing list