[Intel-gfx] [PATCH v3 2/4] drm/i915: fix include order in intel_tc.*

Imre Deak imre.deak at intel.com
Wed Jul 10 13:15:46 UTC 2019


On Tue, Jul 09, 2019 at 08:54:03AM -0700, Lucas De Marchi wrote:
> Separate local includes with a blank line and sort the groups
> alphabetically.
> 
> v2: don't make intel_tc.h be the first include
> v3: don't make local includes be included first
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

Reviewed-by: Imre Deak <imre.deak at intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_tc.c | 2 +-
>  drivers/gpu/drm/i915/display/intel_tc.h | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
> index 1a9dd32fb0a5..0c969f6fd714 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.c
> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
> @@ -3,9 +3,9 @@
>   * Copyright © 2019 Intel Corporation
>   */
>  
> +#include "i915_drv.h"
>  #include "intel_display.h"
>  #include "intel_dp_mst.h"
> -#include "i915_drv.h"
>  #include "intel_tc.h"
>  
>  static const char *tc_port_mode_name(enum tc_port_mode mode)
> diff --git a/drivers/gpu/drm/i915/display/intel_tc.h b/drivers/gpu/drm/i915/display/intel_tc.h
> index 0d8411d4a91d..706c5bc050a5 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.h
> +++ b/drivers/gpu/drm/i915/display/intel_tc.h
> @@ -6,8 +6,9 @@
>  #ifndef __INTEL_TC_H__
>  #define __INTEL_TC_H__
>  
> -#include <linux/types.h>
>  #include <linux/mutex.h>
> +#include <linux/types.h>
> +
>  #include "intel_drv.h"
>  
>  bool intel_tc_port_connected(struct intel_digital_port *dig_port);
> -- 
> 2.21.0
> 


More information about the Intel-gfx mailing list