[Intel-gfx] [PATCH] drm/i915: Don't pass stack garbage to pcode in the second data register

Chris Wilson chris at chris-wilson.co.uk
Wed Jul 10 13:51:54 UTC 2019


Quoting Ville Syrjala (2019-07-10 14:49:37)
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Zero initialize val2 so that we don't pass stack garbage to
> the pcode qgv read command. I suspect in this case pcode
> just ignores the initial value in that registers, but better
> safe than sorry.
> 
> Cc: Dan Carpenter <dan.carpenter at oracle.com>
> Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Fair enough to be defensive,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list