[Intel-gfx] [PATCH 07/12] drm/i915/uc: move GuC and HuC files under gt/uc/

[Michal Wajdeczko]

On Wed, 10 Jul 2019 02:54:32 +0200, Daniele Ceraolo Spurio  
<daniele.ceraolospurio at intel.com> wrote:

> Both microcontrollers are part of the GT HW and are closely related to
> GT operations. To keep all the files cleanly together, they've been
> placed in their own subdir inside the gt/ folder
>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> ---

Acked-by: Michal Wajdeczko <michal.wajdeczko at intel.com>

with some nits below

<snap>

> diff --git a/drivers/gpu/drm/i915/Makefile  
> b/drivers/gpu/drm/i915/Makefile
> index 5266dbeab01f..524516251a40 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -139,16 +139,17 @@ i915-y += \
>  	  intel_wopcm.o
> # general-purpose microcontroller (GuC) support
> -i915-y += intel_uc.o \
> -	  intel_uc_fw.o \
> -	  intel_guc.o \
> -	  intel_guc_ads.o \
> -	  intel_guc_ct.o \
> -	  intel_guc_fw.o \
> -	  intel_guc_log.o \
> -	  intel_guc_submission.o \
> -	  intel_huc.o \
> -	  intel_huc_fw.o
> +obj-y += gt/uc/
> +i915-y += gt/uc/intel_uc.o \

nit: can we put first file on separate line as well, so

i915-y += \

> +	  gt/uc/intel_uc_fw.o \
> +	  gt/uc/intel_guc.o \
> +	  gt/uc/intel_guc_ads.o \
> +	  gt/uc/intel_guc_ct.o \
> +	  gt/uc/intel_guc_fw.o \
> +	  gt/uc/intel_guc_log.o \
> +	  gt/uc/intel_guc_submission.o \
> +	  gt/uc/intel_huc.o \
> +	  gt/uc/intel_huc_fw.o

and iirc bkm is to order all files by name, so uc* should be last