[Intel-gfx] [PATCH 04/12] drm/i915/uc: introduce intel_uc_fw_supported

Michal Wajdeczko michal.wajdeczko at intel.com
Thu Jul 11 12:48:52 UTC 2019


On Wed, 10 Jul 2019 23:46:25 +0200, Daniele Ceraolo Spurio  
<daniele.ceraolospurio at intel.com> wrote:

>
> Maybe instead of saving this info in the uc_fw it'd be better to just  
> change guc_init_early to not do anything if !HAS_GUC and then do  
> something like:
>
> 	bool intel_guc_is_present(guc)
> 	{
> 		return !!guc->send;
> 	}
>
> What do you think? otherwise I'll split it like you suggested

Yes, we can check send instead (but without !! to avoid complains from
Chris, and maybe with some extra comments/GEM_BUG_ON in init_early to
not missed that dual role)

intel_uc_has_guc() will still be there as top level helper, right ?

Thanks,
Michal


More information about the Intel-gfx mailing list