[Intel-gfx] [PATCH] drm/i915: Revert "drm/i915: Enable PSR2 by default"

[Rodrigo Vivi]

On Thu, Jul 11, 2019 at 12:08:12PM +0100, Chris Wilson wrote:
> Quoting Rodrigo Vivi (2019-07-11 12:02:01)
> > On Thu, Jul 11, 2019 at 10:22:54AM +0100, Chris Wilson wrote:
> > > Multiple users are reporting black screens upon boot, after resume, or
> > > frozen after a short period of idleness. A black screen on boot is a
> > > critical issue so disable psr2 again until resolved.
> > > 
> > > This reverts commit 8f6e87d6d561f10cfa48a687345512419839b6d8.
> > > 
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111088
> > 
> > I agree it is critical, but unfortunately this revert won't solve the issue.
> > 
> > [    1.954886] [drm:intel_psr_init_dpcd [i915]] eDP panel supports PSR version 1
> > [    2.003686] [drm:intel_psr_enable_locked [i915]] Enabling PSR1
> > 
> > Users are claiming the regression is only on 5.2 with 5.1 working well
> > and PSR1 is enabled by default since 5.0.
> 
> Hmm, which panels are psr2 and is it being accurately reported?

yes, this part of detection is pretty reliable.
I'd expect PSR2 only on brand new panels

> 
> If you suspect psr1, just revert both for now.

I'm hesitating on the revert because psr worked find for 5.0 and 5.1
and even on the current issue the reproducibility is really low
plus the fact that Jose is on top of that working right now.

but yeap, if more issues start to pop up and time passing by we
will have no choice again.

> -Chris