[Intel-gfx] [PATCH] drm/i915/display: Drop kerneldoc for 'intel_atomic_commit'

Ville Syrjälä ville.syrjala at linux.intel.com
Fri Jul 12 14:24:25 UTC 2019


On Fri, Jul 12, 2019 at 02:42:34PM +0100, Chris Wilson wrote:
> intel_atomic_commit() is not for use internally, but only as an entry
> point from the core drm atomic helper (drm_atomic_commit).
> 
> Squelches the warning for:
> drivers/gpu/drm/i915/display/intel_display.c:14148: warning: Function parameter or member '_state' not described in 'intel_atomic_commit'
> drivers/gpu/drm/i915/display/intel_display.c:14148: warning: Excess function parameter 'state' description in 'intel_atomic_commit'
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index e12671ca1886..9758523f0837 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -14130,18 +14130,6 @@ static void intel_atomic_track_fbs(struct intel_atomic_state *state)
>  				  plane->frontbuffer_bit);
>  }
>  
> -/**
> - * intel_atomic_commit - commit validated state object
> - * @dev: DRM device
> - * @state: the top-level driver state object
> - * @nonblock: nonblocking commit
> - *
> - * This function commits a top-level state object that has been validated
> - * with drm_atomic_helper_check().
> - *
> - * RETURNS
> - * Zero for success or -errno.
> - */
>  static int intel_atomic_commit(struct drm_device *dev,
>  			       struct drm_atomic_state *_state,
>  			       bool nonblock)
> -- 
> 2.22.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel


More information about the Intel-gfx mailing list