[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/24] drm/i915: Hide unshrinkable context objects from the shrinker

Patchwork patchwork at emeril.freedesktop.org
Mon Jul 15 10:11:27 UTC 2019


== Series Details ==

Series: series starting with [01/24] drm/i915: Hide unshrinkable context objects from the shrinker
URL   : https://patchwork.freedesktop.org/series/63704/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
27b7aa232c3a drm/i915: Hide unshrinkable context objects from the shrinker
1da771964799 drm/i915/gt: Move the [class][inst] lookup for engines onto the GT
-:196: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#196: 
new file mode 100644

-:201: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#201: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:1:
+/*

-:202: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#202: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:2:
+ * SPDX-License-Identifier: MIT

-:272: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#272: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.h:1:
+/*

-:273: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#273: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 335 lines checked
d8793a63f716 drm/i915/gtt: Recursive ppgtt alloc for gen8
0531b2530a95 drm/i915/gtt: Tidy up ppgtt insertion for gen8
-:235: WARNING:LONG_LINE: line over 100 characters
#235: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:1331:
+							    i915_pd_entry(pml4, gen8_pd_index(idx, 3)),

total: 0 errors, 1 warnings, 0 checks, 334 lines checked
a30ca32dab48 drm/i915: Lock the engine while dumping the active request
62bdc57ea3ba drm/i915: Rely on spinlock protection for GPU error capture
0a6f23b937dd drm/i915/oa: Reconfigure contexts on the fly
bf2f0758edec drm/i915: Add to timeline requires the timeline mutex
5e0cd64beff0 drm/i915: Teach execbuffer to take the engine wakeref not GT
a4b30a0defce drm/i915/gt: Track timeline activeness in enter/exit
5b81a90414d4 drm/i915/gt: Convert timeline tracking to spinlock
d531da740339 drm/i915/gt: Guard timeline pinning with its own mutex
eb12270767ec drm/i915: Protect request retirement with timeline->mutex
d8457aa7dc9c drm/i915: Replace struct_mutex for batch pool serialisation
-:305: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#305: 
new file mode 100644

-:310: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#310: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.c:1:
+/*

-:311: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#311: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.c:2:
+ * SPDX-License-Identifier: MIT

-:493: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#493: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.h:1:
+/*

-:494: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#494: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.h:2:
+ * SPDX-License-Identifier: MIT

-:533: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#533: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:1:
+/*

-:534: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#534: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:2:
+ * SPDX-License-Identifier: MIT

-:550: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#550: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:18:
+	spinlock_t lock;

total: 0 errors, 7 warnings, 1 checks, 606 lines checked
7ceaac40a247 drm/i915/gt: Mark context->active_count as protected by timeline->mutex
febf50f4193b drm/i915: Forgo last_fence active request tracking
5397db1e54c5 drm/i915/overlay: Switch to using i915_active tracking
ae607b7efb4f drm/i915: Extract intel_frontbuffer active tracking
987bde495314 drm/i915: Markup expected timeline locks for i915_active
-:281: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#281: FILE: drivers/gpu/drm/i915/i915_active_types.h:28:
+	struct mutex *lock;

total: 0 errors, 0 warnings, 1 checks, 233 lines checked
82fde2f441e1 drm/i915: Remove logical HW ID
29b620e651d8 drm/i915: Move context management under GEM
-:451: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#451: FILE: drivers/gpu/drm/i915/i915_drv.h:1828:
+			struct mutex mutex;

total: 0 errors, 0 warnings, 1 checks, 568 lines checked
ed9fdf22bf8e drm/i915: Make debugfs/per_file_stats scale better
-:94: WARNING:LONG_LINE: line over 100 characters
#94: FILE: drivers/gpu/drm/i915/i915_debugfs.c:296:
+		seq_printf(m, "%s: %lu objects, %llu bytes (%llu active, %llu inactive, %llu unbound, %llu closed)\n", \

total: 0 errors, 1 warnings, 0 checks, 85 lines checked
20cfb02ec660 drm/i915/gt: Extract GT runtime power management from intel_pm.c
-:254: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#254: 
new file mode 100644

-:259: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#259: FILE: drivers/gpu/drm/i915/gt/intel_gt_irq.c:1:
+/*

-:260: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#260: FILE: drivers/gpu/drm/i915/gt/intel_gt_irq.c:2:
+ * SPDX-License-Identifier: MIT

-:721: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#721: FILE: drivers/gpu/drm/i915/gt/intel_gt_irq.h:1:
+/*

-:722: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#722: FILE: drivers/gpu/drm/i915/gt/intel_gt_irq.h:2:
+ * SPDX-License-Identifier: MIT

-:872: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#872: FILE: drivers/gpu/drm/i915/gt/intel_gt_pm_irq.c:1:
+/*

-:873: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#873: FILE: drivers/gpu/drm/i915/gt/intel_gt_pm_irq.c:2:
+ * SPDX-License-Identifier: MIT

-:987: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#987: FILE: drivers/gpu/drm/i915/gt/intel_gt_pm_irq.h:1:
+/*

-:988: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#988: FILE: drivers/gpu/drm/i915/gt/intel_gt_pm_irq.h:2:
+ * SPDX-License-Identifier: MIT

-:1039: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#1039: FILE: drivers/gpu/drm/i915/gt/intel_gt_types.h:81:
+	spinlock_t irq_lock;

-:1052: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1052: FILE: drivers/gpu/drm/i915/gt/intel_llc.c:1:
+/*

-:1053: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#1053: FILE: drivers/gpu/drm/i915/gt/intel_llc.c:2:
+ * SPDX-License-Identifier: MIT

-:1178: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1178: FILE: drivers/gpu/drm/i915/gt/intel_llc.h:1:
+/*

-:1179: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#1179: FILE: drivers/gpu/drm/i915/gt/intel_llc.h:2:
+ * SPDX-License-Identifier: MIT

-:1199: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1199: FILE: drivers/gpu/drm/i915/gt/intel_llc_types.h:1:
+/*

-:1200: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#1200: FILE: drivers/gpu/drm/i915/gt/intel_llc_types.h:2:
+ * SPDX-License-Identifier: MIT

-:1218: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1218: FILE: drivers/gpu/drm/i915/gt/intel_rc6.c:1:
+/*

-:1219: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#1219: FILE: drivers/gpu/drm/i915/gt/intel_rc6.c:2:
+ * SPDX-License-Identifier: MIT

-:1889: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1889: FILE: drivers/gpu/drm/i915/gt/intel_rc6.h:1:
+/*

-:1890: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#1890: FILE: drivers/gpu/drm/i915/gt/intel_rc6.h:2:
+ * SPDX-License-Identifier: MIT

-:1919: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1919: FILE: drivers/gpu/drm/i915/gt/intel_rc6_types.h:1:
+/*

-:1920: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#1920: FILE: drivers/gpu/drm/i915/gt/intel_rc6_types.h:2:
+ * SPDX-License-Identifier: MIT

-:2014: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2014: FILE: drivers/gpu/drm/i915/gt/intel_rps.c:1:
+/*

-:2015: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#2015: FILE: drivers/gpu/drm/i915/gt/intel_rps.c:2:
+ * SPDX-License-Identifier: MIT

-:2059: WARNING:LONG_LINE: line over 100 characters
#2059: FILE: drivers/gpu/drm/i915/gt/intel_rps.c:46:
+		mask |= GEN6_PM_RP_UP_EI_EXPIRED | GEN6_PM_RP_DOWN_THRESHOLD | GEN6_PM_RP_DOWN_TIMEOUT;

-:3005: ERROR:TRAILING_WHITESPACE: trailing whitespace
#3005: FILE: drivers/gpu/drm/i915/gt/intel_rps.c:992:
+       $

-:3005: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3005: FILE: drivers/gpu/drm/i915/gt/intel_rps.c:992:
+       $

-:3890: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#3890: FILE: drivers/gpu/drm/i915/gt/intel_rps.h:1:
+/*

-:3891: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#3891: FILE: drivers/gpu/drm/i915/gt/intel_rps.h:2:
+ * SPDX-License-Identifier: MIT

-:3933: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#3933: FILE: drivers/gpu/drm/i915/gt/intel_rps_types.h:1:
+/*

-:3934: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#3934: FILE: drivers/gpu/drm/i915/gt/intel_rps_types.h:2:
+ * SPDX-License-Identifier: MIT

-:4008: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#4008: FILE: drivers/gpu/drm/i915/gt/intel_rps_types.h:76:
+		struct mutex mutex;

total: 1 errors, 29 warnings, 2 checks, 9248 lines checked



More information about the Intel-gfx mailing list