[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/3] drm/gem: don't force writecombine mmap'ing

Patchwork patchwork at emeril.freedesktop.org
Tue Jul 16 22:19:37 UTC 2019


== Series Details ==

Series: series starting with [v3,1/3] drm/gem: don't force writecombine mmap'ing
URL   : https://patchwork.freedesktop.org/series/63770/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b6ec1673874e drm/gem: don't force writecombine mmap'ing
3e4afe6255ab drm: plumb attaching dev thru to prime_pin/unpin
-:145: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#145: FILE: drivers/gpu/drm/nouveau/nouveau_gem.h:35:
+extern int nouveau_gem_prime_pin(struct drm_gem_object *, struct device *);

-:145: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_gem_object *' should also have an identifier name
#145: FILE: drivers/gpu/drm/nouveau/nouveau_gem.h:35:
+extern int nouveau_gem_prime_pin(struct drm_gem_object *, struct device *);

-:145: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#145: FILE: drivers/gpu/drm/nouveau/nouveau_gem.h:35:
+extern int nouveau_gem_prime_pin(struct drm_gem_object *, struct device *);

-:148: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#148: FILE: drivers/gpu/drm/nouveau/nouveau_gem.h:37:
+extern void nouveau_gem_prime_unpin(struct drm_gem_object *, struct device *);

-:148: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_gem_object *' should also have an identifier name
#148: FILE: drivers/gpu/drm/nouveau/nouveau_gem.h:37:
+extern void nouveau_gem_prime_unpin(struct drm_gem_object *, struct device *);

-:148: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#148: FILE: drivers/gpu/drm/nouveau/nouveau_gem.h:37:
+extern void nouveau_gem_prime_unpin(struct drm_gem_object *, struct device *);

total: 0 errors, 4 warnings, 2 checks, 191 lines checked
1eacd563d4f1 drm/vgem: use normal cached mmap'ings



More information about the Intel-gfx mailing list