[Intel-gfx] [PATCH] drm/i915: Update description of i915.enable_guc modparam

Michal Wajdeczko michal.wajdeczko at intel.com
Wed Jul 17 10:47:51 UTC 2019


On Wed, 17 Jul 2019 12:44:18 +0200, Tvrtko Ursulin  
<tvrtko.ursulin at linux.intel.com> wrote:

> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>
> Commit f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode") changed
> the default from 0 to -1 but forgot to update the description.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Fixes: f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Jani Nikula <jani.nikula at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Jani Nikula <jani.nikula at linux.intel.com>
> Cc: intel-gfx at lists.freedesktop.org
> ---

Thanks for catching that,
Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com>

>  drivers/gpu/drm/i915/i915_params.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.c  
> b/drivers/gpu/drm/i915/i915_params.c
> index 296452f9efe4..b4f481e1e6b6 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -146,7 +146,7 @@ i915_param_named_unsafe(edp_vswing, int, 0400,
>  i915_param_named_unsafe(enable_guc, int, 0400,
>  	"Enable GuC load for GuC submission and/or HuC load. "
>  	"Required functionality can be selected using bitmask values. "
> -	"(-1=auto, 0=disable [default], 1=GuC submission, 2=HuC load)");
> +	"(-1=auto [default], 0=disable, 1=GuC submission, 2=HuC load)");
> i915_param_named(guc_log_level, int, 0400,
>  	"GuC firmware logging level. Requires GuC to be loaded. "


More information about the Intel-gfx mailing list