[Intel-gfx] [PATCH] drm/i915: Remove obsolete engine clenaup

Chris Wilson chris at chris-wilson.co.uk
Wed Jul 17 13:24:56 UTC 2019


Quoting Tvrtko Ursulin (2019-07-17 14:18:56)
> 
> On 17/07/2019 08:46, Chris Wilson wrote:
> > Remove the outer layer cleanup of engine stubs; it no longer tries to
> 
> Who is "it"?

i915_drv.c

> > preallocate and so is not responsible for either the allocation or free.
> > By the time we call the cleanup function, we already have cleaned up the
> > engines.
> 
> I see:
> 
> i915_driver_probe
> {
> ...
>         ret = i915_driver_early_probe(dev_priv);
> ...
>         i915_driver_mmio_probe -> intel_engines_init_mmio -> allocates engines
> ...
>         <later step fails> -> who frees the engines?

The mirror of i915_driver_mmio_probe, which would be
i915_driver_mmio_release, should be responsible for cleaning up.
-Chris


More information about the Intel-gfx mailing list