[Intel-gfx] [PATCH] drm/i915/guc: Allocate non-swappable memory for internal objects

Daniele Ceraolo Spurio daniele.ceraolospurio at intel.com
Thu Jul 18 15:35:44 UTC 2019



On 7/18/19 2:29 AM, Chris Wilson wrote:
> All internal GuC objects are perma-pinned into the GGTT and thus
> not-swapped. We do not need to allocate a shmemfs inode for these,
> merely a collection of pages to be kept in memory.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>

Makes sense.

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>

Daniele

> ---
>   drivers/gpu/drm/i915/gt/uc/intel_guc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> index 83f2c197375f..d66f8f9c5654 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> @@ -582,7 +582,7 @@ struct i915_vma *intel_guc_allocate_vma(struct intel_guc *guc, u32 size)
>   	u64 flags;
>   	int ret;
>   
> -	obj = i915_gem_object_create_shmem(gt->i915, size);
> +	obj = i915_gem_object_create_internal(gt->i915, size);
>   	if (IS_ERR(obj))
>   		return ERR_CAST(obj);
>   
> 


More information about the Intel-gfx mailing list