[Intel-gfx] [PATCH] drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY

Chris Wilson chris at chris-wilson.co.uk
Thu Jul 18 20:58:16 UTC 2019


Quoting Rodrigo Vivi (2019-07-18 21:49:12)
> +void intel_display_power_resume_early(struct drm_i915_private *i915)
> +{
> +       if (!HAS_DISPLAY(i915))
> +               return;
> +
> +       if (INTEL_GEN(i915) >= 11 || IS_GEN9_LP(i915)) {
> +               gen9_sanitize_dc_state(i915);

Are you sure that whatever state you are resuming from agrees with your
notion of !display? The sanitize routines are supposed to be about
cleaning up after third parties who don't play by the same rules.
-Chris


More information about the Intel-gfx mailing list