[Intel-gfx] [PATCH 07/22] drm/i915/dmc: Load DMC on TGL

[Lucas De Marchi]

On Fri, Jul 19, 2019 at 04:14:27PM +0530, Anshuman Gupta wrote:
>On 2019-07-12 at 18:09:25 -0700, Lucas De Marchi wrote:
>> From: Anusha Srivatsa <anusha.srivatsa at intel.com>
>>
>> Add Support to load DMC v2.02 on TGL.
>>
>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa at intel.com>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_csr.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
>> index 6ef74531588a..865b987dee8e 100644
>> --- a/drivers/gpu/drm/i915/intel_csr.c
>> +++ b/drivers/gpu/drm/i915/intel_csr.c
>> @@ -39,6 +39,11 @@
>>
>>  #define GEN12_CSR_MAX_FW_SIZE		ICL_CSR_MAX_FW_SIZE
>>
>> +#define TGL_CSR_PATH			"i915/tgl_dmc_ver2_02.bin"
>> +#define TGL_CSR_VERSION_REQUIRED	CSR_VERSION(2, 2)
>> +#define TGL_CSR_MAX_FW_SIZE		0x6000
>> +MODULE_FIRMWARE(TGL_CSR_PATH);
>> +
>>  #define ICL_CSR_PATH			"i915/icl_dmc_ver1_07.bin"
>>  #define ICL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
>>  #define ICL_CSR_MAX_FW_SIZE		0x6000
>> @@ -674,6 +679,8 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)
>>  	intel_csr_runtime_pm_get(dev_priv);
>>
>>  	if (INTEL_GEN(dev_priv) >= 12) {
>> +		csr->fw_path = TGL_CSR_PATH;
>> +		csr->required_version = TGL_CSR_VERSION_REQUIRED;
>>  		/* Allow to load fw via parameter using the last known size */
>>  		csr->max_fw_size = GEN12_CSR_MAX_FW_SIZE;
>>  	} else if (IS_GEN(dev_priv, 11)) {
>LGTM, one concern about DMC fw minor version.
>if this is decided latest upstream version,
>I will provide my RB.

José, 2.02 or 2.03?

Lucas De Marchi

>
>> --
>> 2.21.0
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx