[Intel-gfx] [PATCH 1/2] Revert "drm/i915/guc: Turn on GuC/HuC auto mode"

[Daniele Ceraolo Spurio]

On 7/19/19 2:48 AM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> This reverts commit f774f09649192f326fa030564afd3f8f5d82c1e4.
> 
> If GuC firmware is not present on the filesystem driver crashes the
> machine on boot.
> 

Do you have a log? I can't reproduce this on a SKL, I'm just getting:

[55667.026707] i915 0000:00:02.0: Direct firmware load for 
i915/skl_guc_33.0.0.bin failed with error -2
[55667.026714] [drm] GuC: Failed to fetch firmware 
i915/skl_guc_33.0.0.bin (error -2)
[55667.026717] [drm] GuC: Firmware can be downloaded from 
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/i915
[55667.081885] i915 0000:00:02.0: Device initialization failed (-8)
[55667.081949] i915: probe of 0000:00:02.0 failed with error -8


This is on the latest tip (just fetched).

Daniele

> Fixes: f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Jani Nikula <jani.nikula at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Jani Nikula <jani.nikula at linux.intel.com>
> Cc: intel-gfx at lists.freedesktop.org
> ---
>   drivers/gpu/drm/i915/i915_params.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index 5736c55694fe..d29ade3b7de6 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -54,7 +54,7 @@ struct drm_printer;
>   	param(int, disable_power_well, -1) \
>   	param(int, enable_ips, 1) \
>   	param(int, invert_brightness, 0) \
> -	param(int, enable_guc, -1) \
> +	param(int, enable_guc, 0) \
>   	param(int, guc_log_level, -1) \
>   	param(char *, guc_firmware_path, NULL) \
>   	param(char *, huc_firmware_path, NULL) \
>