[Intel-gfx] [PATCH 5/9] drm/i915/uc: Unify uc_fw status tracking

Chris Wilson chris at chris-wilson.co.uk
Tue Jul 23 08:28:42 UTC 2019


Quoting Daniele Ceraolo Spurio (2019-07-23 00:20:44)
> @@ -219,19 +207,17 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
>  
>         uc_fw->obj = obj;
>         uc_fw->size = fw->size;
> -       uc_fw->fetch_status = INTEL_UC_FIRMWARE_SUCCESS;
> -       DRM_DEBUG_DRIVER("%s fw fetch %s\n",
> -                        intel_uc_fw_type_repr(uc_fw->type),
> -                        intel_uc_fw_status_repr(uc_fw->fetch_status));
> +       uc_fw->status = INTEL_UC_FIRMWARE_FETCHED;
> +       DRM_DEBUG_DRIVER("%s fw fetch done\n",
> +                        intel_uc_fw_type_repr(uc_fw->type));

I don't see much value in the success message, they just get followed by
more success messages. Pointless spam imo.
-Chris


More information about the Intel-gfx mailing list