[Intel-gfx] [PATCH v3 4/8] drm/i915/uc: Unify uc_fw status tracking

[Michal Wajdeczko]

On Thu, 25 Jul 2019 02:18:09 +0200, Daniele Ceraolo Spurio  
<daniele.ceraolospurio at intel.com> wrote:

> We currently track fetch and load status separately, but the 2 are
> actually sequential in the uc lifetime (fetch must complete before we
> can attempt the load!). Unifying the 2 variables we can better follow
> the sequential states and improve our trackng of the uC state.
>
> Also, sprinkle some GEM_BUG_ON to make sure we transition correctly
> between states.
>
> v2: rename states, add the running state (Michal), drop some logs in
>     the fetch path (Michal, Chris)
>
> v3: re-rename states, extend early status check to all helpers (Michal)
>
> Suggested-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> ---

Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com>

...

> +static inline bool intel_huc_is_authenticated(struct intel_huc *huc)
> +{
> +	return intel_uc_fw_is_running(&huc->fw);
> +}
> +

btw, maybe later we can use that instead of intel_huc_check_status() ?