[Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

[Takashi Iwai]

On Thu, 25 Jul 2019 10:03:00 +0200,
Chris Wilson wrote:
> 
> Just a heads up that icl is consistently showing
> 
> <4> [315.478830] snd_hda_intel 0000:00:1f.3: azx_get_response timeout, switching to polling mode: last cmd=0x202f8100
> <4> [316.482799] snd_hda_intel 0000:00:1f.3: No response from codec, disabling MSI: last cmd=0x202f8100
> <3> [508.412915] snd_hda_codec_hdmi hdaudioC0D2: Unable to sync register 0x2f8100. -11
> 
> following commits 2756d9143aa5 ("ALSA: hda - Fix intermittent CORB/RIRB
> stall on Intel chips") and a30f1743e4f5 ("ALSA: line6: sizeof (byte) is
> always 1, use that fact.")

The verb that stalls (0x202f8100) is a read verb (0xf81, Intel
vendor-specific verb for HDMI), so it shouldn't matter whether with or
without write sync, because it needs to read the response in anyway.

If that patch broke anything, it means that something else was already
broken.  Oh well, that ICL crap...

Is it about the runtime PM, or S3 or S4?  The only case we need to
re-issue this verb is only S4, I suppose, so we may skip that in most
cases.


thanks,

Takashi

> 
> Cc: Takashi Iwai <tiwai at suse.de>
> ---
>  sound/pci/hda/hda_intel.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 324a4b20fba9..fdde80d95966 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -313,10 +313,11 @@ enum {
>  
>  #define AZX_DCAPS_INTEL_SKYLAKE \
>  	(AZX_DCAPS_INTEL_PCH_BASE | AZX_DCAPS_PM_RUNTIME |\
> -	 AZX_DCAPS_SYNC_WRITE |\
>  	 AZX_DCAPS_SEPARATE_STREAM_TAG | AZX_DCAPS_I915_COMPONENT)
>  
> -#define AZX_DCAPS_INTEL_BROXTON		AZX_DCAPS_INTEL_SKYLAKE
> +#define AZX_DCAPS_INTEL_BROXTON \
> +	(AZX_DCAPS_INTEL_PCH_BASE | AZX_DCAPS_PM_RUNTIME |\
> +	 AZX_DCAPS_SEPARATE_STREAM_TAG | AZX_DCAPS_I915_COMPONENT)
>  
>  /* quirks for ATI SB / AMD Hudson */
>  #define AZX_DCAPS_PRESET_ATI_SB \
> -- 
> 2.22.0
>