[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/27] drm/i915/gt: Add to timeline requires the timeline mutex

[Patchwork]

== Series Details ==

Series: series starting with [01/27] drm/i915/gt: Add to timeline requires the timeline mutex
URL   : https://patchwork.freedesktop.org/series/64291/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f555b9441b90 drm/i915/gt: Add to timeline requires the timeline mutex
18d1675037c0 drm/i915: Unshare the idle-barrier from other kernel requests
-:112: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#112: 
new file mode 100644

-:117: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#117: FILE: drivers/gpu/drm/i915/gt/selftest_context.c:1:
+/*

-:118: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#118: FILE: drivers/gpu/drm/i915/gt/selftest_context.c:2:
+ * SPDX-License-Identifier: GPL-2.0

total: 0 errors, 3 warnings, 0 checks, 519 lines checked
beecf8263bb1 drm/i915/execlists: Force preemption
8927d1ee404f drm/i915: Replace hangcheck by heartbeats
-:136: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#136: 
new file mode 100644

-:141: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#141: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:1:
+/*

-:142: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#142: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:2:
+ * SPDX-License-Identifier: MIT

-:191: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'heartbeat', this function's name, in a string
#191: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:51:
+					      "stopped heartbeat on %s",

-:246: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#246: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.h:1:
+/*

-:247: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#247: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 6 warnings, 0 checks, 594 lines checked
cd7f497c7196 drm/i915/gem: Make caps.scheduler static
112d87e777cb drm/i915: Move aliasing_ppgtt underneath its i915_ggtt
a25479f98264 drm/i915/gt: Provide a local intel_context.vm
bd9fa13ff7d9 drm/i915: Remove lrc default desc from GEM context
3d3cad52cd48 drm/i915: Push the ring creation flags to the backend
7cbc803ba569 drm/i915: Flush extra hard after writing relocations through the GTT
738184e584b1 drm/i915: Hide unshrinkable context objects from the shrinker
e08d4f96fad5 drm/i915/gt: Move the [class][inst] lookup for engines onto the GT
-:223: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#223: 
new file mode 100644

-:228: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#228: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:1:
+/*

-:229: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#229: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:2:
+ * SPDX-License-Identifier: MIT

-:300: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#300: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.h:1:
+/*

-:301: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#301: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 415 lines checked
76c415210376 drm/i915: Introduce for_each_user_engine()
-:198: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'engine__' - possible side-effects?
#198: FILE: drivers/gpu/drm/i915/i915_drv.h:1921:
+#define for_each_user_engine(engine__, i915__) \
+	for ((engine__) = rb_to_uabi_engine(rb_first(&(i915__)->uabi_engines));\
+	     (engine__); \
+	     (engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))

total: 0 errors, 0 warnings, 1 checks, 172 lines checked
85073c6c425b drm/i915: Use intel_engine_lookup_user for probing HAS_BSD etc
e0e1ecfeacb2 drm/i915: Isolate i915_getparam_ioctl()
-:235: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#235: 
new file mode 100644

-:240: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#240: FILE: drivers/gpu/drm/i915/i915_getparam.c:1:
+/*

-:241: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#241: FILE: drivers/gpu/drm/i915/i915_getparam.c:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 3 warnings, 0 checks, 372 lines checked
1030d3f5697a drm/i915: Only include active engines in the capture state
00aa8d691a61 drm/i915: Teach execbuffer to take the engine wakeref not GT
f7f67e7ffdde drm/i915/gt: Track timeline activeness in enter/exit
b15ccb1217e2 drm/i915/gt: Convert timeline tracking to spinlock
b4d14163746c drm/i915/gt: Guard timeline pinning with its own mutex
2d6850c9e396 drm/i915: Protect request retirement with timeline->mutex
63303d7bfc6a drm/i915: Replace struct_mutex for batch pool serialisation
-:305: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#305: 
new file mode 100644

-:310: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#310: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.c:1:
+/*

-:311: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#311: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.c:2:
+ * SPDX-License-Identifier: MIT

-:493: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#493: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.h:1:
+/*

-:494: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#494: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool.h:2:
+ * SPDX-License-Identifier: MIT

-:533: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#533: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:1:
+/*

-:534: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#534: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:2:
+ * SPDX-License-Identifier: MIT

-:550: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#550: FILE: drivers/gpu/drm/i915/gt/intel_engine_pool_types.h:18:
+	spinlock_t lock;

total: 0 errors, 7 warnings, 1 checks, 604 lines checked
2bbd819de41e drm/i915/gt: Mark context->active_count as protected by timeline->mutex
990e82abd938 drm/i915: Forgo last_fence active request tracking
c6d439fc4d4f drm/i915/overlay: Switch to using i915_active tracking
ac8fd2d3a79f drm/i915: Extract intel_frontbuffer active tracking
2101c0561681 drm/i915: Markup expected timeline locks for i915_active
-:263: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#263: FILE: drivers/gpu/drm/i915/i915_active_types.h:28:
+	struct mutex *lock;

total: 0 errors, 0 warnings, 1 checks, 217 lines checked