[Intel-gfx] [PATCH] drm/i915/uc: Don't sanitize guc_log_level modparam

Chris Wilson chris at chris-wilson.co.uk
Fri Jul 26 10:54:30 UTC 2019


Quoting Michal Wajdeczko (2019-07-25 21:51:06)
> We are already storing runtime value of log level in private
> field, so there is no need to modify modparam.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>

Michal is persuasive that having already broken the link between the
modparam and the actual value set via debugfs, no one can currently
trust the value reported by modparam.

In that respect, this should not have noticeable userspace consequences
and is just another step along the road of removing the modparam
entirely.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list