[Intel-gfx] [PATCH 1/2] drm/i915/perf: Initialise err to 0 before looping over ce->engines

Chris Wilson chris at chris-wilson.co.uk
Fri Jul 26 12:54:55 UTC 2019


Smatch warning that the loop may be empty causing us to check err before
it had been set. Ensure that it is initialised to 0, just in case.

Fixes: a9877da2d629 ("drm/i915/oa: Reconfigure contexts on the fly")
Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
---
 drivers/gpu/drm/i915/i915_perf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index 79be9d8ea628..a294c0f53625 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -1875,6 +1875,7 @@ static int gen8_configure_all_contexts(struct drm_i915_private *i915,
 		if (ctx == i915->kernel_context)
 			continue;
 
+		err = 0;
 		for_each_gem_engine(ce,
 				    i915_gem_context_lock_engines(ctx),
 				    it) {
-- 
2.22.0



More information about the Intel-gfx mailing list