[Intel-gfx] [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

[Chris Wilson]

Quoting Thomas Gleixner (2019-07-25 22:55:45)
> On Thu, 25 Jul 2019, Josh Poimboeuf wrote:
> 
> > Objtool reports:
> > 
> >   drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: .altinstr_replacement+0x36: redundant UACCESS disable
> > 
> > __copy_from_user() already does both STAC and CLAC, so the
> > user_access_end() in its error path adds an extra unnecessary CLAC.
> > 
> > Fixes: 0b2c8f8b6b0c ("i915: fix missing user_access_end() in page fault exception case")
> > Reported-by: Thomas Gleixner <tglx at linutronix.de>
> > Reported-by: Sedat Dilek <sedat.dilek at gmail.com>
> > Acked-by: Peter Zijlstra (Intel) <peterz at infradead.org>
> > Tested-by: Nick Desaulniers <ndesaulniers at google.com>
> > Tested-by: Sedat Dilek <sedat.dilek at gmail.com>
> > Link: https://github.com/ClangBuiltLinux/linux/issues/617
> > Signed-off-by: Josh Poimboeuf <jpoimboe at redhat.com>
> 
> Reviewed-by: Thomas Gleixner <tglx at linutronix.de>

Which tree do you plan to apply it to? I can put in drm-intel, and with
the fixes tag it will percolate through to 5.3 and beyond, but if you
want to apply it directly to squash the build warnings, feel free.
-Chris