[Intel-gfx] [PATCH 6/6] drm/i915/gt: introduce intel_gt_suspend

Chris Wilson chris at chris-wilson.co.uk
Tue Jul 30 08:12:11 UTC 2019


Quoting Tvrtko Ursulin (2019-07-30 08:33:28)
> 
> On 30/07/2019 00:47, Daniele Ceraolo Spurio wrote:
> > For symmetry with intel_gt_resume and to hide more stuff from the top
> > level under intel_gt. Note that the switch_to_kernel_context_sync has
> > not been moved dure to the locking and ordering requirements that exist
> 
> Typo in due.
> 
> Should we add intel_gt_suspend_early/late, with the former dealing with 
> switch_to_kernel_context_sync? Although that raises an interesting 
> conundrum since it operates on GEM and GT. Best then to leave it 
> unwrapped for now I think.
> 
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Ah, I wouldn't apply this patch yet for exactly that reason: we
shouldn't be driving GT suspend from inside GEM, so would wait until we
have a few more pieces of the puzzle reviewed^W unravelled.
-Chris


More information about the Intel-gfx mailing list