[Intel-gfx] [PATCH 3/4] drm/i915/tgl: Gen12 csb support

Chris Wilson chris at chris-wilson.co.uk
Wed Jul 31 07:33:21 UTC 2019


Quoting Daniele Ceraolo Spurio (2019-07-31 01:49:01)
> @@ -1401,7 +1453,7 @@ static void process_csb(struct intel_engine_cs *engine)
>                           engine->name, head,
>                           buf[2 * head + 0], buf[2 * head + 1]);
>  
> -               switch (csb_parse(execlists, buf + 2 * head)) {
> +               switch (execlists->csb_parse(execlists, buf + 2 * head)) {

So I worry about the cost of a retpoline here (tucked away inside an
irqs-off loop), and whether a local func avoids the retpoline or if we
just have to use an if-ladder.
-Chris


More information about the Intel-gfx mailing list