[Intel-gfx] [PATCH v2] drm/i915/selftests: Pass intel_context to igt_spinner
Chris Wilson
chris at chris-wilson.co.uk
Wed Jul 31 08:08:15 UTC 2019
Quoting Tvrtko Ursulin (2019-07-31 08:37:44)
>
> On 31/07/2019 08:00, Chris Wilson wrote:
> > @@ -1183,11 +1191,16 @@ live_engine_reset_workarounds(void *arg)
> > goto err;
> > }
> >
> > - ret = igt_spinner_init(&spin, i915);
> > - if (ret)
> > - goto err;
> > + ce = i915_gem_context_get_engine(ctx, engine->id);
> > + if (IS_ERR(ce))
>
> I thought with locked engines you would be able to drop the get/put in
> the loop. Wrong? Request will take a reference..
Yeah... You mean it didn't automatically remove the old ce getter.
Stupid refactoring bot. I'll demote it to coffee maker.
-Chris
More information about the Intel-gfx
mailing list