[Intel-gfx] [PATCH v2 4/4] drm/i915/uc: Stop sanitizing enable_guc modparam

Chris Wilson chris at chris-wilson.co.uk
Wed Jul 31 20:55:36 UTC 2019


Quoting Michal Wajdeczko (2019-07-31 15:38:56)
> -       /* Make sure that sanitization was done */
> -       GEM_BUG_ON(i915_modparams.enable_guc < 0);
> +       if (i915_modparams.enable_guc & ~(ENABLE_GUC_SUBMISSION ||
> +                                         ENABLE_GUC_LOAD_HUC))
> +               DRM_INFO("Incompatible option enable_guc=%d - %s\n",
> +                        i915_modparams.enable_guc, "undocumented flag");

You know something is wrong when DRM_INFO is right! (That is modparams
being global and not tied to any device;
rmdir /sys/modules/i915/parameters!)
-Chris


More information about the Intel-gfx mailing list