[Intel-gfx] [PATCH v2 1/4] drm/i915/uc: Rename intel_uc_is_using* into intel_uc_supports*

Michal Wajdeczko michal.wajdeczko at intel.com
Wed Jul 31 22:23:35 UTC 2019


On Wed, 31 Jul 2019 22:49:57 +0200, Chris Wilson  
<chris at chris-wilson.co.uk> wrote:

> Quoting Michal Wajdeczko (2019-07-31 15:38:53)
>> @@ -365,12 +365,12 @@ void intel_uc_fini(struct intel_uc *uc)
>>  {
>>         struct intel_guc *guc = &uc->guc;
>>
>> -       if (!intel_uc_is_using_guc(uc))
>> +       if (!intel_uc_supports_guc(uc))
>>                 return;
>
> Note by this point we should know whether or not we loaded the guc and
> need to cleanup. So here is_using_guc() does read better. If we even
> need to bother and just leave it to the huc_fini / guc_fini to be no-ops
> when there is nothing to do.

note that here we already have sanitized uc even if it was loaded
and note that we also have intel_uc_fini_hw()


More information about the Intel-gfx mailing list