[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/15] drm/i915: Make the semaphore saturation mask global

Patchwork patchwork at emeril.freedesktop.org
Mon Jun 3 16:56:18 UTC 2019


== Series Details ==

Series: series starting with [01/15] drm/i915: Make the semaphore saturation mask global
URL   : https://patchwork.freedesktop.org/series/61524/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
73098627036b drm/i915: Make the semaphore saturation mask global
03932e224987 drm: Flush output polling on shutdown
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11: 
<4> [341.846497] WARNING: CPU: 3 PID: 3300 at kernel/locking/mutex-debug.c:103 mutex_destroy+0x49/0x50

total: 0 errors, 1 warnings, 0 checks, 21 lines checked
bef084dfd0fc drm/i915/selftests: Flush partial-tiling object once
5518d5a5bcf1 drm/i915: Use unchecked writes for setting up the fences
88a48ffab798 drm/i915: Use unchecked unccore writes to flush the GTT
fb725e75a68e drm/i915: Report an earlier wedged event when suspending the engines
0505eaa83ac9 drm/i915: Move object close under its own lock
b875658ce204 drm/i915: Keep contexts pinned until after the next kernel context switch
4f00dab1b645 drm/i915: Stop retiring along engine
5c83798408f4 drm/i915: Replace engine->timeline with a plain list
-:180: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#180: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:292:
+		spinlock_t lock;

total: 0 errors, 0 warnings, 1 checks, 968 lines checked
a3bd899e85cb drm/i915: Flush the execution-callbacks on retiring
687140deab24 drm/i915/execlists: Preempt-to-busy
-:1494: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p_ptr' - possible side-effects?
#1494: FILE: drivers/gpu/drm/i915/i915_utils.h:134:
+#define ptr_count_dec(p_ptr) do {					\
+	typeof(p_ptr) __p = (p_ptr);					\
+	unsigned long __v = (unsigned long)(*__p);			\
+	*__p = (typeof(*p_ptr))(--__v);					\
+} while (0)

-:1500: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p_ptr' - possible side-effects?
#1500: FILE: drivers/gpu/drm/i915/i915_utils.h:140:
+#define ptr_count_inc(p_ptr) do {					\
+	typeof(p_ptr) __p = (p_ptr);					\
+	unsigned long __v = (unsigned long)(*__p);			\
+	*__p = (typeof(*p_ptr))(++__v);					\
+} while (0)

-:1783: WARNING:LINE_SPACING: Missing a blank line after declarations
#1783: FILE: drivers/gpu/drm/i915/intel_guc_submission.c:820:
+		int rem = ARRAY_SIZE(execlists->inflight) - idx;
+		memmove(execlists->inflight, port, rem * sizeof(*port));

total: 0 errors, 1 warnings, 2 checks, 1682 lines checked
db2939f074b6 drm/i915/execlists: Minimalistic timeslicing
-:345: WARNING:LONG_LINE: line over 100 characters
#345: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:211:
+			      2 * RUNTIME_INFO(outer->i915)->num_engines * (count + 2) * (count + 3)) < 0) {

total: 0 errors, 1 warnings, 0 checks, 426 lines checked
2b1890df5891 drm/i915/execlists: Force preemption
-:51: WARNING:LONG_LINE: line over 100 characters
#51: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1224:
+				  jiffies + msecs_to_jiffies_timeout(CONFIG_DRM_I915_PREEMPT_TIMEOUT));

total: 0 errors, 1 warnings, 0 checks, 87 lines checked
fb14188d4b6e drm/i915: Add a label for config DRM_I915_SPIN_REQUEST



More information about the Intel-gfx mailing list