[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix TypeC port mode switching

Patchwork patchwork at emeril.freedesktop.org
Tue Jun 4 17:30:53 UTC 2019


== Series Details ==

Series: drm/i915: Fix TypeC port mode switching
URL   : https://patchwork.freedesktop.org/series/61590/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
14db34664cf1 drm/i915/icl: Add support to read out the TBT PLL HW state
90cdad322f0f drm/i915: Tune down WARNs about TBT AUX power well enabling
ee8152f95440 drm/i915: Move the TypeC port handling code to a separate file
-:16: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#16: 
- s/intel_dp_get_fia_supported_lane_count()/intel_tc_port_fia_max_lane_count()/

-:371: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#371: 
new file mode 100644

-:552: CHECK:LINE_SPACING: Please don't use multiple blank lines
#552: FILE: drivers/gpu/drm/i915/intel_tc.c:177:
+
+

-:612: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#612: FILE: drivers/gpu/drm/i915/intel_tc.h:1:
+#ifndef __INTEL_TC_H__

total: 0 errors, 3 warnings, 1 checks, 554 lines checked
fa3cd0d9851c drm/i915: Sanitize the terminology used for TypeC port modes
2c6f803c95c9 drm/i915: Don't enable the DDI-IO power in the TypeC TBT-alt mode
b98f89ef27e8 drm/i915: Fix the TBT AUX power well enabling
de2d578fdfab drm/i915: Use the correct AUX power domain in TypeC TBT-alt mode
4b3efd91dc32 drm/i915: Unify the TypeC port notation in debug/error messages
-:38: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#38: FILE: drivers/gpu/drm/i915/intel_tc.c:21:
+	if (WARN_ON(INTEL_GEN(dev_priv) < 11 ||
+	    (unsigned int)tc_port >= I915_MAX_TC_PORTS))

total: 0 errors, 0 warnings, 1 checks, 77 lines checked
bc3a3c77a3f5 drm/i915: Factor out common parts from TypeC port handling functions
ebb66c60f3cf drm/i915: Wait for TypeC PHY complete flag to clear in safe mode
58c036477acb drm/i915: Handle the TCCOLD power-down event
95125fafe1ec drm/i915: Sanitize the TypeC connect/detect sequences
dfbe290320f4 drm/i915: Fix the TypeC port mode sanitization during loading/resume
224419d6882e drm/i915: Keep the TypeC port mode fixed for detect/AUX transfers
-:88: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#88: FILE: drivers/gpu/drm/i915/intel_drv.h:1227:
+	struct mutex tc_lock;

total: 0 errors, 0 warnings, 1 checks, 116 lines checked
c42d11cbf62e drm/i915: Sanitize the TypeC FIA lane configuration decoding
919f648b1dc1 drm/i915: Sanitize the shared DPLL reserve/release interface
-:527: WARNING:TYPO_SPELLING: 'succesfully' may be misspelled - perhaps 'successfully'?
#527: FILE: drivers/gpu/drm/i915/intel_dpll_mgr.c:3349:
+ * True if all required DPLLs were succesfully reserved.

total: 0 errors, 1 warnings, 0 checks, 542 lines checked
cb7a3ff173c9 drm/i915: Sanitize the shared DPLL find/reference interface
38fef1eb02de drm/i915/icl: Split getting the DPLLs to port type specific functions
4653a4e49ccc drm/i915/icl: Reserve all required PLLs for TypeC ports
97faef600998 drm/i915: Keep the TypeC port mode fixed when the port is active
94663bce7d66 drm/i915: Add state verification for the TypeC port mode
cbe3469c83b3 drm/i915: Remove unneeded disconnect in TypeC legacy port mode
ead9432bec38 drm/i915: WARN about invalid lane reversal in TBT-alt/DP-alt modes



More information about the Intel-gfx mailing list