[Intel-gfx] [PATCH i-g-t 1/5] lib/tests: fix conflicting args test

[Petri Latvala]

On 6/5/19 12:38 AM, Lucas De Marchi wrote:
> On Fri, May 31, 2019 at 07:55:45AM -0700, Lucas De Marchi wrote:
>> On Fri, May 31, 2019 at 12:59:35PM +0300, Petri Latvala wrote:
>>> On Wed, May 29, 2019 at 04:27:33PM -0700, Lucas De Marchi wrote:
>>>> We want to check if the long option conflicts with one from the core.
>>>> The check for conflicting short option already exists just above.
>>>
>>> No, this one is checking that the val (the 0) doesn't conflict.
>>
>> My point is that this check is already done above. We don't need to do
>> it again.


There's two val conflict tests. One checks for conflicts against core 
short options, the latter (modified here) checks for conflicts against 
core long option values.



>>
>> If you insist, then we will need to raise it to magic number 500,
>> because 0 won't be a conflict after this series.

Yeah that would be the correct change.



Petri